Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new adopter #1938

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Conversation

j4ckstraw
Copy link
Contributor

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Signed-off-by: j4ckstraw <j4ckstraw@foxmail.com>
@j4ckstraw
Copy link
Contributor Author

cc @jiasheng55

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.48%. Comparing base (c590941) to head (2eae475).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1938   +/-   ##
=======================================
  Coverage   67.47%   67.48%           
=======================================
  Files         420      420           
  Lines       46856    46856           
=======================================
+ Hits        31618    31620    +2     
  Misses      12937    12937           
+ Partials     2301     2299    -2     
Flag Coverage Δ
unittests 67.48% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hormes
Copy link
Member

hormes commented Mar 5, 2024

Wellcome!

@hormes hormes added the lgtm label Mar 5, 2024
@ZiMengSheng
Copy link
Contributor

ZiMengSheng commented Mar 5, 2024

Welcome!

@eahydra
Copy link
Member

eahydra commented Mar 5, 2024

Welcome! 🎉 🚀 🎉 🚀 🎉 🚀 🎉 🚀

@saintube
Copy link
Member

saintube commented Mar 5, 2024

Long awaited, welcome!

@jasonliu747
Copy link
Member

Welcome!!!

/lgtm

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 03f89eb into koordinator-sh:main Mar 5, 2024
20 checks passed
ls-2018 pushed a commit to ls-2018/koordinator that referenced this pull request Mar 25, 2024
Signed-off-by: j4ckstraw <j4ckstraw@foxmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants