Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apis: add Resctrl API #1943

Merged
merged 1 commit into from
Mar 22, 2024
Merged

Conversation

kangclzjc
Copy link
Member

@kangclzjc kangclzjc commented Mar 8, 2024

Ⅰ. Describe what this PR does

Add resctrl API. The API should be like below which you can refer to proposal of resctrl enhance

{
  "llc": {
    "schemata": {
      "range": [20,80],
    },
    "schemataPerCache": [
      {
        "cacheid" : 0,
        "range": [20,50]
      },
      {
        "cacheid" : 1,
        "range": [20,60]
      },
    ],
  },
  "mb": {
    "schemata": {
      "percent": 20,
    },
    "schemataPerCache": [
      {
        "cacheid": 0,
        "percent": 20
      },
      {
        "cacheid": 1,
        "percent": 40
      },
    ],
  }
}

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@koordinator-bot koordinator-bot bot requested review from FillZpp and hormes March 8, 2024 03:53
Copy link

codecov bot commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.51%. Comparing base (3581c3d) to head (0f6a578).
Report is 14 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1943   +/-   ##
=======================================
  Coverage   67.51%   67.51%           
=======================================
  Files         420      420           
  Lines       46954    46961    +7     
=======================================
+ Hits        31703    31708    +5     
+ Misses      12944    12943    -1     
- Partials     2307     2310    +3     
Flag Coverage Δ
unittests 67.51% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kangclzjc kangclzjc force-pushed the dev-resctrl-api branch 4 times, most recently from 07d2209 to a9fa6fc Compare March 8, 2024 04:14
@saintube saintube changed the title add resctrl api apis: add Resctrl API Mar 8, 2024
apis/extension/resctrl.go Outdated Show resolved Hide resolved
apis/extension/resctrl.go Outdated Show resolved Hide resolved
apis/extension/resctrl.go Outdated Show resolved Hide resolved
apis/extension/resctrl.go Outdated Show resolved Hide resolved
@kangclzjc kangclzjc force-pushed the dev-resctrl-api branch 2 times, most recently from 8ada691 to c0e39c1 Compare March 12, 2024 07:41
apis/extension/resctrl.go Outdated Show resolved Hide resolved
Signed-off-by: Zhang Kang <kang.zhang@intel.com>
@saintube
Copy link
Member

/lgtm
PTAL @hormes @FillZpp @zwzhang0107 @eahydra

@zwzhang0107
Copy link
Contributor

/lgtm

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 025d3bf into koordinator-sh:main Mar 22, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants