Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koordlet: fix GetAllPods error and wrong tsdb prometheus registry #1944

Conversation

saintube
Copy link
Member

@saintube saintube commented Mar 8, 2024

Ⅰ. Describe what this PR does

koordlet:

  1. Fix the outdated configured Prometheus registry for the TSDB.
  2. Fix the panic when the kubeletStub GetAllPods/GetKubeletConfiguration returns a nil response.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Signed-off-by: saintube <saintube@foxmail.com>
Copy link

codecov bot commented Mar 8, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 67.52%. Comparing base (3581c3d) to head (b87321d).

Files Patch % Lines
pkg/koordlet/metriccache/tsdb_storage.go 0.00% 1 Missing ⚠️
pkg/koordlet/statesinformer/impl/kubelet_stub.go 90.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1944   +/-   ##
=======================================
  Coverage   67.51%   67.52%           
=======================================
  Files         420      420           
  Lines       46954    46957    +3     
=======================================
+ Hits        31703    31707    +4     
+ Misses      12944    12939    -5     
- Partials     2307     2311    +4     
Flag Coverage Δ
unittests 67.52% <81.81%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zwzhang0107
Copy link
Contributor

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zwzhang0107

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 36ad576 into koordinator-sh:main Mar 8, 2024
20 checks passed
ls-2018 pushed a commit to ls-2018/koordinator that referenced this pull request Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants