scheduler: improve the failed event of Reservation's scheduling #1947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1947 +/- ##
=======================================
Coverage 67.50% 67.51%
=======================================
Files 420 420
Lines 46961 47040 +79
=======================================
+ Hits 31703 31760 +57
- Misses 12949 12968 +19
- Partials 2309 2312 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
eahydra
reviewed
Mar 13, 2024
buptcozy
reviewed
Mar 13, 2024
Signed-off-by: wangjianyu.wjy <wangjianyu.wjy@alibaba-inc.com>
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: buptcozy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ls-2018
pushed a commit
to ls-2018/koordinator
that referenced
this pull request
Mar 25, 2024
…dinator-sh#1947) Signed-off-by: wangjianyu.wjy <wangjianyu.wjy@alibaba-inc.com> Co-authored-by: wangjianyu.wjy <wangjianyu.wjy@alibaba-inc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
The reservation plugin of koord-scheduler traverses all reservations with the Restricted policy and determines whether a certain Reservation satisfies the Pod. When all reservations cannot be satisfied, we lose reasonable information, such as which resources cannot be satisfied, which can help users diagnose themselves.
So this PR aggregate these messages to users.
Ⅱ. Does this pull request fix one issue?
fixes #1909
Ⅲ. Describe how to verify it
make pods requiring allocate resource from reservation, check the failed event, like follows.
Warning FailedScheduling 12s default-scheduler 0/50 nodes are available: 1 Insufficient cpu by reservation.Ⅳ. Special notes for reviews
V. Checklist
make test