Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

descheduler: change the order of check len(lowNodes) and len(sourceNodes) #1957

Merged
merged 1 commit into from
Mar 19, 2024
Merged

descheduler: change the order of check len(lowNodes) and len(sourceNodes) #1957

merged 1 commit into from
Mar 19, 2024

Conversation

bogo-y
Copy link
Contributor

@bogo-y bogo-y commented Mar 15, 2024

Ⅰ. Describe what this PR does

We firstly check len(lowNodes) after classifyNodes, which cloud lead to the sourceNodes lose a chance to be mark as abnormal. If we change the order, the sourceNodes cloud be evict more quickly when we just add a new node to a overloaded cluster.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Copy link

codecov bot commented Mar 15, 2024

Codecov Report

Attention: Patch coverage is 55.55556% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 67.52%. Comparing base (beaafa3) to head (40a0a08).
Report is 1 commits behind head on main.

Files Patch % Lines
...duler/framework/plugins/loadaware/low_node_load.go 55.55% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1957   +/-   ##
=======================================
  Coverage   67.52%   67.52%           
=======================================
  Files         420      420           
  Lines       47040    47047    +7     
=======================================
+ Hits        31764    31769    +5     
- Misses      12965    12971    +6     
+ Partials     2311     2307    -4     
Flag Coverage Δ
unittests 67.52% <55.55%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@eahydra eahydra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@eahydra
Copy link
Member

eahydra commented Mar 15, 2024

please add signature with command git commit -s --amend --no-edit

Signed-off-by: bogo <bogo.ysh@gmail.com>
@koordinator-bot koordinator-bot bot removed the lgtm label Mar 18, 2024
@bogo-y
Copy link
Contributor Author

bogo-y commented Mar 18, 2024

/retest-required

@koordinator-bot
Copy link

@bogo-y: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest-required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bogo-y bogo-y requested a review from eahydra March 18, 2024 03:20
@eahydra
Copy link
Member

eahydra commented Mar 19, 2024

/lgtm
/approve

@koordinator-bot koordinator-bot bot added the lgtm label Mar 19, 2024
@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eahydra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 7540b72 into koordinator-sh:main Mar 19, 2024
20 checks passed
@bogo-y bogo-y deleted the descheduler-markabnormal branch March 19, 2024 13:38
ls-2018 pushed a commit to ls-2018/koordinator that referenced this pull request Mar 25, 2024
j4ckstraw pushed a commit to j4ckstraw/koordinator that referenced this pull request May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants