-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
descheduler: change the order of check len(lowNodes) and len(sourceNodes) #1957
descheduler: change the order of check len(lowNodes) and len(sourceNodes) #1957
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1957 +/- ##
=======================================
Coverage 67.52% 67.52%
=======================================
Files 420 420
Lines 47040 47047 +7
=======================================
+ Hits 31764 31769 +5
- Misses 12965 12971 +6
+ Partials 2311 2307 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
please add signature with command |
Signed-off-by: bogo <bogo.ysh@gmail.com>
/retest-required |
@bogo-y: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eahydra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…des) (koordinator-sh#1957) Signed-off-by: bogo <bogo.ysh@gmail.com>
…des) (koordinator-sh#1957) Signed-off-by: bogo <bogo.ysh@gmail.com>
Ⅰ. Describe what this PR does
We firstly check len(lowNodes) after classifyNodes, which cloud lead to the sourceNodes lose a chance to be mark as abnormal. If we change the order, the sourceNodes cloud be evict more quickly when we just add a new node to a overloaded cluster.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test