Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koordlet: record invoke metrics for runtime hook #1961

Conversation

saintube
Copy link
Member

Ⅰ. Describe what this PR does

koordlet: add the following metrics to record the runtime hook's execution:

  • koordlet_runtime_hook_invoked_duration_milliseconds
  • koordlet_runtime_hook_reconciler_invoked_duration_milliseconds

Ⅱ. Does this pull request fix one issue?

Part of #1867.

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Signed-off-by: saintube <saintube@foxmail.com>
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Attention: Patch coverage is 67.44186% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 67.54%. Comparing base (f3bc42a) to head (f4f1703).

Files Patch % Lines
pkg/koordlet/runtimehooks/reconciler/reconciler.go 55.55% 7 Missing and 1 partial ⚠️
pkg/koordlet/metrics/runtime_hook.go 75.00% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1961      +/-   ##
==========================================
+ Coverage   67.52%   67.54%   +0.02%     
==========================================
  Files         420      421       +1     
  Lines       47047    47084      +37     
==========================================
+ Hits        31767    31803      +36     
+ Misses      12968    12967       -1     
- Partials     2312     2314       +2     
Flag Coverage Δ
unittests 67.54% <67.44%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zwzhang0107
Copy link
Contributor

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zwzhang0107

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 0272196 into koordinator-sh:main Mar 29, 2024
20 checks passed
georgexiang pushed a commit to ocichina/koordinator that referenced this pull request Apr 15, 2024
Signed-off-by: saintube <saintube@foxmail.com>
Signed-off-by: george <xiangzhihua@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants