descheduler: only include the overused resources when sorting removable pods #1962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1962 +/- ##
=======================================
Coverage 67.54% 67.55%
=======================================
Files 420 420
Lines 47050 47058 +8
=======================================
+ Hits 31781 31789 +8
+ Misses 12958 12957 -1
- Partials 2311 2312 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: bogo <bogo.ysh@gmail.com>
|
/assign @eahydra |
bogo-y
changed the title
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eahydra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
j4ckstraw
pushed a commit
to j4ckstraw/koordinator
that referenced
this pull request
May 20, 2024
…le pods (koordinator-sh#1962) Signed-off-by: bogo <bogo.ysh@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have global weights for resources in LowNodeLoad plugin, and we sort pods on abnormal nodes based on these weights and their usage. In most cases, a abnormal node only has one kind of resource that is overutilized, so we may need to adjust the weights according to the actual situation before sorting the removable pods. I had a idea that we only include the overused resource for each pod through preparing weights before sorting. Could you give more suggestions?
Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test