scheduler : fix deviceshare plugin of add\remove pod #1963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xulinfei.xlf <xulinfei.xlf@alibaba-inc.com>
xulinfei1996
force-pushed
the
device-share
branch
from
63ec988
to
c937fc8
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1963 +/- ##
==========================================
+ Coverage 67.55% 67.60% +0.05%
==========================================
Files 420 421 +1
Lines 47058 47145 +87
==========================================
+ Hits 31788 31872 +84
+ Misses 12961 12959 -2
- Partials 2309 2314 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: buptcozy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
xulinfei1996
pushed a commit
to xulinfei1996/koordinator
that referenced
this pull request
Mar 25, 2024
…ator-sh#1963)" This reverts commit ad01533.
xulinfei1996
pushed a commit
to xulinfei1996/koordinator
that referenced
this pull request
Mar 25, 2024
…tor-sh#1963) Signed-off-by: xulinfei.xlf <xulinfei.xlf@alibaba-inc.com>
ls-2018
pushed a commit
to ls-2018/koordinator
that referenced
this pull request
Mar 25, 2024
…1963) Signed-off-by: xulinfei.xlf <xulinfei.xlf@alibaba-inc.com> Co-authored-by: xulinfei.xlf <xulinfei.xlf@alibaba-inc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
fix deviceshare plugin of add\remove pod. For example, pod A preempts a pod in node1 in the last round preemption. If the next to schedule pod is pod B, framework will add pod A when RunFiltersWithNominatedsPod. However, the deviceSharePlugin's allocation result of pod A is not stored. As a result, the resources nominated by pod A may be occupied by pod B, although pod B's priority is lower than pod A, this case will be happened in fractional gpu allocation or topology aware allocation.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test