Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webhook: fix priority admission conflict #1968

Merged

Commits on Mar 21, 2024

  1. fix priority admission conflict

    when we set priorityclass koord-xxx with preemptionPolicy=Never,
    priority admission refuse to create pod with error like this:
    ```text
    pods "test" is forbidden: the string value of PreemptionPolicy
    (PreemptLowerPriority) must not be provided in pod spec; priority
    admission controller computed Never from the given PriorityClass name
    ```
    
    we overwrite PriorityClassName/Priority in cluster_colocation_profile,
    so as well PreemptionPolicy.
    
    see
    https://github.com/kubernetes/kubernetes/blob/master/plugin/pkg/admission/priority/admission.go#L188
    
    Signed-off-by: j4ckstraw <j4ckstraw@foxmail.com>
    j4ckstraw committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    21befaf View commit details
    Browse the repository at this point in the history