Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chores: fix some fmt err #1970

Merged
merged 1 commit into from
Apr 8, 2024
Merged

Conversation

ls-2018
Copy link
Contributor

@ls-2018 ls-2018 commented Mar 25, 2024

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Copy link

codecov bot commented Mar 25, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 67.55%. Comparing base (cd58ac6) to head (aed19e7).
Report is 6 commits behind head on main.

Files Patch % Lines
.../collectors/coldmemoryresource/cold_page_kidled.go 0.00% 2 Missing ⚠️
...oordlet/runtimehooks/protocol/container_context.go 33.33% 2 Missing ⚠️
pkg/util/metrics/expire_metric.go 0.00% 2 Missing ⚠️
pkg/descheduler/controllers/migration/evict.go 0.00% 1 Missing ⚠️
...g/koordlet/qosmanager/framework/pod_qos_control.go 0.00% 1 Missing ⚠️
...let/qosmanager/plugins/cpusuppress/cpu_suppress.go 0.00% 1 Missing ⚠️
...kg/koordlet/runtimehooks/hooks/coresched/helper.go 50.00% 1 Missing ⚠️
.../koordlet/runtimehooks/hooks/groupidentity/rule.go 0.00% 1 Missing ⚠️
...kg/koordlet/statesinformer/impl/callback_runner.go 0.00% 1 Missing ⚠️
pkg/koordlet/statesinformer/impl/states_pods.go 0.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1970      +/-   ##
==========================================
- Coverage   67.56%   67.55%   -0.02%     
==========================================
  Files         420      420              
  Lines       47059    47058       -1     
==========================================
- Hits        31795    31789       -6     
- Misses      12955    12957       +2     
- Partials     2309     2312       +3     
Flag Coverage Δ
unittests 67.55% <33.33%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hormes
Copy link
Member

hormes commented Mar 25, 2024

Great job.

Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Signed-off-by: acejilam <acejilam@gmail.com>
Copy link
Member

@saintube saintube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@koordinator-bot koordinator-bot bot added the lgtm label Mar 26, 2024
@zwzhang0107 zwzhang0107 changed the title koordlet: fix some fmt err chores: fix some fmt err Apr 7, 2024
@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes, saintube

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit d1a1e1a into koordinator-sh:main Apr 8, 2024
20 checks passed
georgexiang pushed a commit to ocichina/koordinator that referenced this pull request Apr 15, 2024
Signed-off-by: acejilam <acejilam@gmail.com>
Signed-off-by: george <xiangzhihua@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants