-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koordlet: add NRI reconnect #1972
koordlet: add NRI reconnect #1972
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1972 +/- ##
==========================================
+ Coverage 67.55% 68.73% +1.17%
==========================================
Files 420 423 +3
Lines 47059 39246 -7813
==========================================
- Hits 31789 26974 -4815
+ Misses 12961 9937 -3024
- Partials 2309 2335 +26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
1782aef
to
fa835ea
Compare
37c954c
to
1e9b75b
Compare
@saintube PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
PTAL cc @zwzhang0107 @hormes |
094d565
to
9c7b462
Compare
Signed-off-by: Zhang Kang <kang.zhang@intel.com>
/PTAL @zwzhang0107. Add some explanation in the parameters configuration |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zwzhang0107 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ⅰ. Describe what this PR does
Currently, if containerd restart or upgrade, koordlet will lost connection between koordlet and containerd. This PR will reconnect to containerd.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Restart containerd and see koordlet hooks still work.
Ⅳ. Special notes for reviews
V. Checklist
make test