Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koordlet: add NRI reconnect #1972

Merged
merged 1 commit into from
May 10, 2024

Conversation

kangclzjc
Copy link
Member

@kangclzjc kangclzjc commented Mar 26, 2024

Ⅰ. Describe what this PR does

Currently, if containerd restart or upgrade, koordlet will lost connection between koordlet and containerd. This PR will reconnect to containerd.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Restart containerd and see koordlet hooks still work.

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 54.38596% with 26 lines in your changes are missing coverage. Please review.

Project coverage is 68.73%. Comparing base (af5f951) to head (9c7b462).
Report is 41 commits behind head on main.

Files Patch % Lines
pkg/koordlet/runtimehooks/nri/server.go 32.35% 22 Missing and 1 partial ⚠️
pkg/koordlet/runtimehooks/runtimehooks.go 76.92% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1972      +/-   ##
==========================================
+ Coverage   67.55%   68.73%   +1.17%     
==========================================
  Files         420      423       +3     
  Lines       47059    39246    -7813     
==========================================
- Hits        31789    26974    -4815     
+ Misses      12961     9937    -3024     
- Partials     2309     2335      +26     
Flag Coverage Δ
unittests 68.73% <54.38%> (+1.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kangclzjc kangclzjc changed the title koordlet: add NRI reconnect(WIP) koordlet: add NRI reconnect Apr 12, 2024
@kangclzjc kangclzjc force-pushed the dev-nri-reconnect branch 2 times, most recently from 37c954c to 1e9b75b Compare April 26, 2024 08:42
@kangclzjc
Copy link
Member Author

@saintube PTAL.

Copy link
Member

@saintube saintube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@saintube
Copy link
Member

saintube commented May 6, 2024

PTAL cc @zwzhang0107 @hormes

Signed-off-by: Zhang Kang <kang.zhang@intel.com>
@kangclzjc
Copy link
Member Author

kangclzjc commented May 9, 2024

/PTAL @zwzhang0107. Add some explanation in the parameters configuration

@zwzhang0107
Copy link
Contributor

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zwzhang0107

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit afa430a into koordinator-sh:main May 10, 2024
20 checks passed
@saintube saintube added this to the v1.5 milestone May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants