Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slo-controller: refactor codes for reading #1973

Merged

Conversation

hormes
Copy link
Member

@hormes hormes commented Mar 26, 2024

Ⅰ. Describe what this PR does

Here we just adjusted the naming of the code and added a diagram to explain the calculation logic of Batch resources. The code logic has not been changed.

Signed-off-by: Fansong Zeng <fanster.z@gmail.com>
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 92.59259% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 67.54%. Comparing base (cd58ac6) to head (09aa753).
Report is 2 commits behind head on main.

Files Patch % Lines
...troller/noderesource/plugins/batchresource/util.go 90.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1973      +/-   ##
==========================================
- Coverage   67.56%   67.54%   -0.02%     
==========================================
  Files         420      420              
  Lines       47059    47060       +1     
==========================================
- Hits        31795    31787       -8     
- Misses      12955    12960       +5     
- Partials     2309     2313       +4     
Flag Coverage Δ
unittests 67.54% <92.59%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zwzhang0107
Copy link
Contributor

we also have a node.koordinator.sh/system-qos-resource inside koordinator reserve, which is used for pod with system qos.

@hormes
Copy link
Member Author

hormes commented Mar 27, 2024

we also have a node.koordinator.sh/system-qos-resource inside koordinator reserve, which is used for pod with system qos.

It is in koordinator, the reason I won't elaborate here is to make it easier to understand. There will be a user document later to explain in detail some of the details and how to use it.

@zwzhang0107
Copy link
Contributor

/lgtm

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 006c232 into koordinator-sh:main Apr 7, 2024
20 checks passed
georgexiang pushed a commit to ocichina/koordinator that referenced this pull request Apr 12, 2024
Signed-off-by: Fansong Zeng <fanster.z@gmail.com>
Signed-off-by: george <xiangzhihua@gmail.com>
georgexiang pushed a commit to ocichina/koordinator that referenced this pull request Apr 15, 2024
Signed-off-by: Fansong Zeng <fanster.z@gmail.com>
Signed-off-by: george <xiangzhihua@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants