apis & slo-controller: allow specifying node-wise total bandwidth via annotation #1982
Conversation
|
@zwzhang0107 PTAL |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1982 +/- ##
==========================================
+ Coverage 68.63% 68.68% +0.04%
==========================================
Files 421 421
Lines 38778 38787 +9
==========================================
+ Hits 26616 26641 +25
+ Misses 9847 9834 -13
+ Partials 2315 2312 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
remember to commit with -s |
sjtufl
force-pushed
the
feat/netqos-node-bandwidth
branch
from
9ca7b09
to
1170f25
Compare
done |
sjtufl
force-pushed
the
feat/netqos-node-bandwidth
branch
from
1170f25
to
31df962
Compare
|
/assign @zwzhang0107 |
zwzhang0107
force-pushed
the
feat/netqos-node-bandwidth
branch
from
31df962
to
628d77b
Compare
|
/lgtm |
Signed-off-by: sjtufl <jerryfang555@qq.com>
…r cluster or node strategy Signed-off-by: sjtufl <jerryfang555@qq.com>
sjtufl
force-pushed
the
feat/netqos-node-bandwidth
branch
from
628d77b
to
d6e8842
Compare
|
/lgtm |
|
@zwzhang0107 @hormes PTAL, just renamed api to |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FillZpp, jasonliu747, zwzhang0107 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
… annotation (koordinator-sh#1982) Signed-off-by: sjtufl <jerryfang555@qq.com> Signed-off-by: george <xiangzhihua@gmail.com>
Ⅰ. Describe what this PR does
Introduce an extension API (through annotation) to specify the total bandwidth for a node. This parameter takes precedence over ones configured in cluster strategy or node strategy, and will take effect in NodeSLO.
Ⅱ. Does this pull request fix one issue?
fixes #1883 (part 1).