Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI workflow with codecov token #1989

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

FillZpp
Copy link
Member

@FillZpp FillZpp commented Apr 8, 2024

Ⅰ. Describe what this PR does

CI workflow with codecov token

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jasonliu747

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Siyu Wang <FillZpp.pub@gmail.com>
@koordinator-bot
Copy link

New changes are detected. LGTM label has been removed.

@koordinator-bot koordinator-bot bot removed the lgtm label Apr 8, 2024
Copy link

codecov bot commented Apr 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.69%. Comparing base (2dc8735) to head (94372d1).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1989      +/-   ##
==========================================
+ Coverage   67.50%   68.69%   +1.18%     
==========================================
  Files         421      421              
  Lines       47100    38779    -8321     
==========================================
- Hits        31795    26638    -5157     
+ Misses      12990     9831    -3159     
+ Partials     2315     2310       -5     
Flag Coverage Δ
unittests 68.69% <ø> (+1.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FillZpp FillZpp added the lgtm label Apr 8, 2024
@koordinator-bot koordinator-bot bot merged commit ae23cc9 into koordinator-sh:main Apr 8, 2024
20 checks passed
georgexiang pushed a commit to ocichina/koordinator that referenced this pull request Apr 15, 2024
Signed-off-by: Siyu Wang <FillZpp.pub@gmail.com>
Signed-off-by: george <xiangzhihua@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants