-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scheduler: add new pod estimate with loadaware plugin #1992
scheduler: add new pod estimate with loadaware plugin #1992
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1992 +/- ##
==========================================
+ Coverage 67.50% 68.75% +1.25%
==========================================
Files 421 423 +2
Lines 47100 39174 -7926
==========================================
- Hits 31795 26936 -4859
+ Misses 12990 9909 -3081
- Partials 2315 2329 +14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
84026c9
to
8e7711f
Compare
52e117b
to
dcb76fe
Compare
What is the status of this issue? |
27b00fa
to
5b1bba3
Compare
The corresponding changes have been updated. |
I'm sorry I've been away from X for a while. I reviewed this PR and reviewed the implementation of the loadaware plugin. I noticed that there are many areas that need to be improved in the code I implemented in the past. Especially in this PR, you can see that the logic of filter and score are very similar. We should calculate the usage first, and then decide whether to score or filter. When calculating usage, we can decide whether to use estimated. These codes should be wrapped as a function that can be used in filter and score stage. koordinator/pkg/scheduler/plugins/loadaware/load_aware.go Lines 291 to 327 in 038308b
|
Yes, I noticed this issue while making the changes. I will further modify this part. |
4304b54
to
8943b2d
Compare
@zwForrest Thanks for your contributions! Please resolve the conflicts and we will continue the review. |
b2d4a43
to
0a6249c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1992 +/- ##
==========================================
+ Coverage 68.61% 68.62% +0.01%
==========================================
Files 430 430
Lines 39668 39652 -16
==========================================
- Hits 27218 27212 -6
+ Misses 10095 10088 -7
+ Partials 2355 2352 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Done, The ci error is caused by other code. @saintube |
bcaa7dc
to
0a6249c
Compare
ad20f2c
to
c77ed01
Compare
|
Signed-off-by: zwForrest <756495135@qq.com>
b40fb8e
to
ba58826
Compare
@saintube Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
PTAL /cc @ZiMengSheng
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ZiMengSheng The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…#1992) Signed-off-by: zwForrest <756495135@qq.com> Co-authored-by: zengwang1 <zengwang1@xiaomi.com>
Ⅰ. Describe what this PR does
When scheduling a new pod, it is necessary to consider the resource utilization of the new pod with the loadaware plugin, to prevent the node utilization from becoming too high after the new pod is scheduled.
This can prevent nodes with excessive utilization entering score phase.
The resource utilization for the new pod here is calculated using the original estimated method.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test