Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

descheduler: allow annotated pod pass non-retrievable filter #1994

Merged
merged 1 commit into from
Apr 12, 2024
Merged

descheduler: allow annotated pod pass non-retrievable filter #1994

merged 1 commit into from
Apr 12, 2024

Conversation

ZiMengSheng
Copy link
Contributor

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov Codecov
Copy link

codecov bot commented Apr 10, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 68.65%. Comparing base (ae23cc9) to head (c677691).
Report is 7 commits behind head on main.

Files Patch % Lines
...heduler/controllers/migration/arbitrator/filter.go 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1994      +/-   ##
==========================================
- Coverage   68.67%   68.65%   -0.03%     
==========================================
  Files         421      421              
  Lines       38779    38779              
==========================================
- Hits        26632    26622      -10     
- Misses       9835     9846      +11     
+ Partials     2312     2311       -1
Flag Coverage Δ
unittests 68.65% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zwzhang0107
Copy link
Contributor

one more ut for this？

descheduler: allow annotated pod pass non-retrievable filter
c677691 
Signed-off-by: wangjianyu.wjy <wangjianyu.wjy@alibaba-inc.com>
@zwzhang0107
Copy link
Contributor

/lgtm
/approve

@koordinator-bot koordinator-bot bot added the lgtm label Apr 11, 2024
@FillZpp
Copy link
Member

FillZpp commented Apr 11, 2024

/lgtm

@FillZpp
Copy link
Member

FillZpp commented Apr 12, 2024

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FillZpp, zwzhang0107

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 2fb6fc4 into koordinator-sh:main Apr 12, 2024
20 checks passed
georgexiang pushed a commit to ocichina/koordinator that referenced this pull request Apr 15, 2024
@ZiMengSheng @georgexiang
descheduler: allow annotated pod pass non-retrievable filter (koordin…
7d0d17a 
…ator-sh#1994)

Signed-off-by: wangjianyu.wjy <wangjianyu.wjy@alibaba-inc.com>
Co-authored-by: wangjianyu.wjy <wangjianyu.wjy@alibaba-inc.com>
Signed-off-by: george <xiangzhihua@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eahydra eahydra Awaiting requested review from eahydra

@FillZpp FillZpp Awaiting requested review from FillZpp

Assignees

@FillZpp FillZpp

@zwzhang0107 zwzhang0107

Labels
approved lgtm size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ZiMengSheng @zwzhang0107 @FillZpp