scheduler: no rejecting sbiling when invalid scheduling cycle #1999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZiMengSheng
force-pushed
the
shouldnotreject
branch
from
1df8679
to
34a4b55
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1999 +/- ##
==========================================
- Coverage 68.70% 68.68% -0.02%
==========================================
Files 421 421
Lines 38822 38845 +23
==========================================
+ Hits 26672 26682 +10
- Misses 9842 9851 +9
- Partials 2308 2312 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: wangjianyu.wjy <wangjianyu.wjy@alibaba-inc.com>
ZiMengSheng
force-pushed
the
shouldnotreject
branch
from
34a4b55
to
bf2848e
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: buptcozy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
georgexiang
pushed a commit
to ocichina/koordinator
that referenced
this pull request
Apr 15, 2024
…nator-sh#1999) Signed-off-by: wangjianyu.wjy <wangjianyu.wjy@alibaba-inc.com> Co-authored-by: wangjianyu.wjy <wangjianyu.wjy@alibaba-inc.com> Signed-off-by: george <xiangzhihua@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
PodA1 invalid cycle PreFilter 会 Reject 已经 assumed 的兄弟 Gang GangB的 Pod，然后兄弟GangB 会将 GangA 的 cycle++；然后 GangA 继续 invalid cycle ......，就会一直循环下去；
之所以选择在 PreFilter 里面改，而不是在 PostFilter 通过判断 cycleValid 决定是否reject，是因为 PostFilter 逻辑无法判断是因为什么原因导致的 cycleInvalid，有可能cycle 一开始就是 invalid的，然后现在用户删除了gang 或者 pod ，这种情况也是需要reject的，否则会导致死锁
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test