Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

descheduler: Add detail logs for nonRemovable pods #2000

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

zwForrest
Copy link
Contributor

Ⅰ. Describe what this PR does

Add detail logs for nonRemovable pods

Ⅱ. Does this pull request fix one issue?

fixes #1773

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@koordinator-bot koordinator-bot bot requested review from eahydra and FillZpp April 12, 2024 02:39
@zwForrest zwForrest force-pushed the feat/loadawarefilter branch from 2482e49 to 1636f7f Compare April 12, 2024 02:42
Copy link

codecov bot commented Apr 12, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 68.66%. Comparing base (c579dd5) to head (abd2786).
Report is 23 commits behind head on main.

Files Patch % Lines
...ler/controllers/migration/arbitrator/arbitrator.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2000      +/-   ##
==========================================
+ Coverage   68.64%   68.66%   +0.01%     
==========================================
  Files         421      421              
  Lines       38778    38832      +54     
==========================================
+ Hits        26621    26665      +44     
- Misses       9842     9857      +15     
+ Partials     2315     2310       -5     
Flag Coverage Δ
unittests 68.66% <90.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zwForrest zwForrest force-pushed the feat/loadawarefilter branch 3 times, most recently from e26fbca to fc22346 Compare April 12, 2024 03:13
Signed-off-by: zwForrest <756495135@qq.com>
@zwForrest zwForrest force-pushed the feat/loadawarefilter branch from fc22346 to abd2786 Compare April 12, 2024 03:13
@saintube saintube changed the title Add detail logs for nonRemovable pods descheduler: Add detail logs for nonRemovable pods Apr 15, 2024
@hormes
Copy link
Member

hormes commented Apr 28, 2024

/lgtm

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 907232f into koordinator-sh:main Apr 29, 2024
20 checks passed
@zwForrest zwForrest deleted the feat/loadawarefilter branch July 10, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[proposal] Add more detail logs for nonRemovable pods
2 participants