Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler: add more quota details used and request in quotaInfo #2001

Merged

Conversation

xulinfei1996
Copy link
Contributor

Ⅰ. Describe what this PR does

If allow parent quota submit pods, show parent self used and request.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@koordinator-bot koordinator-bot bot requested review from buptcozy and eahydra April 12, 2024 07:59
@xulinfei1996 xulinfei1996 force-pushed the refine-quota-details branch 3 times, most recently from bfcb4e9 to cb83865 Compare April 12, 2024 08:38
Copy link

codecov bot commented Apr 12, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 68.71%. Comparing base (2dc8735) to head (304822f).
Report is 13 commits behind head on main.

Files Patch % Lines
.../scheduler/plugins/elasticquota/core/quota_info.go 86.11% 7 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2001      +/-   ##
==========================================
+ Coverage   67.50%   68.71%   +1.20%     
==========================================
  Files         421      421              
  Lines       47100    38899    -8201     
==========================================
- Hits        31795    26728    -5067     
+ Misses      12990     9858    -3132     
+ Partials     2315     2313       -2     
Flag Coverage Δ
unittests 68.71% <88.88%> (+1.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: xulinfei.xlf <xulinfei.xlf@alibaba-inc.com>
@xulinfei1996 xulinfei1996 force-pushed the refine-quota-details branch from cb83865 to 304822f Compare April 12, 2024 09:04
Copy link
Contributor

@buptcozy buptcozy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: buptcozy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit e64e74b into koordinator-sh:main Apr 15, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants