Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler: refine coscheduling fairness consider gangGroup #2004

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

buptcozy
Copy link
Contributor

…heduleTime (#2003)

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@buptcozy buptcozy force-pushed the xbb1 branch 5 times, most recently from 08a6c80 to 1761aa7 Compare April 15, 2024 05:03
@buptcozy buptcozy force-pushed the xbb1 branch 3 times, most recently from f33faa8 to 8ca1d3d Compare April 15, 2024 06:47
Copy link

codecov bot commented Apr 15, 2024

Codecov Report

Attention: Patch coverage is 89.10506% with 28 lines in your changes are missing coverage. Please review.

Project coverage is 68.81%. Comparing base (2fb6fc4) to head (d32ee99).
Report is 6 commits behind head on main.

Files Patch % Lines
pkg/scheduler/plugins/coscheduling/core/core.go 53.33% 14 Missing ⚠️
.../scheduler/plugins/coscheduling/core/gang_cache.go 90.16% 4 Missing and 2 partials ⚠️
...cheduler/plugins/coscheduling/core/gang_summary.go 0.00% 4 Missing ⚠️
pkg/scheduler/plugins/coscheduling/core/gang.go 96.72% 2 Missing ⚠️
pkg/scheduler/plugins/coscheduling/coscheduling.go 85.71% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2004      +/-   ##
==========================================
+ Coverage   68.66%   68.81%   +0.15%     
==========================================
  Files         421      422       +1     
  Lines       38846    39022     +176     
==========================================
+ Hits        26672    26852     +180     
+ Misses       9862     9852      -10     
- Partials     2312     2318       +6     
Flag Coverage Δ
unittests 68.81% <89.10%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@buptcozy buptcozy force-pushed the xbb1 branch 3 times, most recently from b6f6539 to 6b88f48 Compare April 15, 2024 08:33
@hormes
Copy link
Member

hormes commented Apr 17, 2024

/lgtm

@buptcozy
Copy link
Contributor Author

/lgtm

@koordinator-bot
Copy link

@buptcozy: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@buptcozy buptcozy changed the title scheduler: refine coscheduling fairness consider gangGroup and lastSc… scheduler: refine coscheduling fairness consider gangGroup Apr 18, 2024
@koordinator-bot koordinator-bot bot removed the lgtm label Apr 18, 2024
@ZiMengSheng
Copy link
Contributor

/lgtm

…r-sh#2003)

Signed-off-by: xingbao.zy <xingbao.zy@alibaba-inc.com>
@ZiMengSheng
Copy link
Contributor

/lgtm

@koordinator-bot koordinator-bot bot added the lgtm label Apr 18, 2024
@buptcozy
Copy link
Contributor Author

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: buptcozy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 211250b into koordinator-sh:main Apr 18, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants