Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koordlet: add resctrl qos collector #2005

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Rouzip
Copy link

@Rouzip Rouzip commented Apr 15, 2024

Ⅰ. Describe what this PR does

Add resctrl qos collector.

Ⅱ. Does this pull request fix one issue?

fixes #1832

Ⅲ. Describe how to verify it

After enable resctrl flag in config:

curl http://localhost:9316/metrics|grep resctrl

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Copy link

codecov bot commented Apr 15, 2024

Codecov Report

Attention: Patch coverage is 51.75439% with 110 lines in your changes missing coverage. Please review.

Project coverage is 68.58%. Comparing base (2fb6fc4) to head (13e06eb).
Report is 78 commits behind head on main.

Files Patch % Lines
...icsadvisor/collectors/resctrl/resctrl_collector.go 19.40% 54 Missing ⚠️
pkg/koordlet/resourceexecutor/resctrl.go 58.33% 18 Missing and 12 partials ⚠️
pkg/koordlet/util/system/resctrl.go 80.76% 10 Missing ⚠️
pkg/koordlet/metrics/resctrl.go 0.00% 9 Missing ⚠️
pkg/koordlet/metriccache/metric_types.go 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2005      +/-   ##
==========================================
- Coverage   68.66%   68.58%   -0.08%     
==========================================
  Files         421      438      +17     
  Lines       38846    40921    +2075     
==========================================
+ Hits        26672    28064    +1392     
- Misses       9862    10435     +573     
- Partials     2312     2422     +110     
Flag Coverage Δ
unittests 68.58% <51.75%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Rouzip <1226015390@qq.com>
@koordinator-bot koordinator-bot bot added size/XXL and removed size/XL labels May 9, 2024
@Rouzip Rouzip changed the title koordlet: add resctrl qos collector(WIP) koordlet: add resctrl qos collector May 9, 2024
@Rouzip
Copy link
Author

Rouzip commented May 9, 2024

Sorry for the late pr, any comments is welcome.

Signed-off-by: Rouzip <1226015390@qq.com>
pkg/koordlet/metrics/resctrl.go Outdated Show resolved Hide resolved
pkg/koordlet/util/system/resctrl.go Outdated Show resolved Hide resolved
pkg/koordlet/resourceexecutor/resctrl.go Outdated Show resolved Hide resolved
pkg/koordlet/resourceexecutor/resctrl.go Show resolved Hide resolved
@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign fillzpp, zwzhang0107 after the PR has been reviewed.
You can assign the PR to them by writing /assign @fillzpp @zwzhang0107 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Rouzip Rouzip force-pushed the collect branch 2 times, most recently from 2d1efd6 to c28c849 Compare May 29, 2024 03:29
@Rouzip
Copy link
Author

Rouzip commented Jun 25, 2024

hello, PTAL 😊 @saintube

Signed-off-by: Rouzip <1226015390@qq.com>
Signed-off-by: Rouzip <1226015390@qq.com>
@saintube
Copy link
Member

@Rouzip Thanks for your great contributions. Since it is a large patch, we need to make some tests before it is merged.

@Rouzip
Copy link
Author

Rouzip commented Jul 15, 2024

@Rouzip Thanks for your great contributions. Since it is a large patch, we need to make some tests before it is merged.

😊 Anything I can do?

@saintube
Copy link
Member

saintube commented Jul 16, 2024

@Rouzip Thanks for your great contributions. Since it is a large patch, we need to make some tests before it is merged.

😊 Anything I can do?

We will verify this patch on some test environments later. It would also be appreciated if you could add more UTs to increase the coverage to no less than the target of 70%.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[proposal] QoS class level LLC/MBA metrics collector
2 participants