-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koordlet: add resctrl qos collector #2005
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2005 +/- ##
==========================================
- Coverage 68.66% 68.58% -0.08%
==========================================
Files 421 438 +17
Lines 38846 40921 +2075
==========================================
+ Hits 26672 28064 +1392
- Misses 9862 10435 +573
- Partials 2312 2422 +110
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Rouzip <1226015390@qq.com>
Sorry for the late pr, any comments is welcome. |
Signed-off-by: Rouzip <1226015390@qq.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2d1efd6
to
c28c849
Compare
hello, PTAL 😊 @saintube |
Signed-off-by: Rouzip <1226015390@qq.com>
Signed-off-by: Rouzip <1226015390@qq.com>
@Rouzip Thanks for your great contributions. Since it is a large patch, we need to make some tests before it is merged. |
😊 Anything I can do? |
We will verify this patch on some test environments later. It would also be appreciated if you could add more UTs to increase the coverage to no less than the target of 70%. |
Ⅰ. Describe what this PR does
Add resctrl qos collector.
Ⅱ. Does this pull request fix one issue?
fixes #1832
Ⅲ. Describe how to verify it
After enable resctrl flag in config:
curl http://localhost:9316/metrics|grep resctrl
Ⅳ. Special notes for reviews
V. Checklist
make test