Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler: improve gang log #2009

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

googs1025
Copy link
Contributor

Ⅰ. Describe what this PR does

I modified the current log level output method. In order to reduce log printing, I only print when --v=4 is used, and use klog.V().ErrorS for the err!=nil part.

Ⅱ. Does this pull request fix one issue?

fix: #1895 (comment)

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Signed-off-by: googs1025 <googs1025@gmail.com>
Copy link

codecov bot commented Apr 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.70%. Comparing base (e15a68c) to head (298ae4c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2009   +/-   ##
=======================================
  Coverage   67.69%   67.70%           
=======================================
  Files         446      446           
  Lines       42686    42686           
=======================================
+ Hits        28898    28899    +1     
+ Misses      11269    11265    -4     
- Partials     2519     2522    +3     
Flag Coverage Δ
unittests 67.70% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@googs1025
Copy link
Contributor Author

@buptcozy @eahydra /PTAL

@hormes
Copy link
Member

hormes commented Apr 28, 2024

Why do we need to downgrade error logs to V4?

@googs1025
Copy link
Contributor Author

Why do we need to downgrade error logs to V4?

Indeed, this level needs to be confirmed. However, setting the log level can effectively reduce the number of log prints.

@eahydra eahydra changed the title fix: fix gang log level scheduler: improve gang log May 7, 2024
@jasonliu747
Copy link
Member

/assign @ZiMengSheng

@ZiMengSheng
Copy link
Contributor

/lgtm

@koordinator-bot koordinator-bot bot added the lgtm label Aug 5, 2024
@googs1025
Copy link
Contributor Author

Sorry for being late. I've been busy with other work recently. I'll go through the comments and make some revisions during the holidays.

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot removed the lgtm label Sep 2, 2024
@koordinator-bot
Copy link

New changes are detected. LGTM label has been removed.

@hormes hormes added lgtm and removed approved labels Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[proposal] improve coscheduling's log
5 participants