Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler: refine restricted topology policy #2010

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

ZiMengSheng
Copy link
Contributor

@ZiMengSheng ZiMengSheng commented Apr 17, 2024

Ⅰ. Describe what this PR does

将 NUMA 对齐策略 Restricted 与上游 Kubelet 逻辑对齐,即不同资源的 Hint 的 NUMAAffinity 一样时,才讲该 merged 后的 Hint 置为 preferred

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Signed-off-by: wangjianyu.wjy <wangjianyu.wjy@alibaba-inc.com>
Copy link

codecov bot commented Apr 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.68%. Comparing base (e64e74b) to head (0ff02f2).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2010      +/-   ##
==========================================
- Coverage   68.70%   68.68%   -0.02%     
==========================================
  Files         421      421              
  Lines       38899    38916      +17     
==========================================
+ Hits        26726    26730       +4     
- Misses       9855     9873      +18     
+ Partials     2318     2313       -5     
Flag Coverage Δ
unittests 68.68% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ZiMengSheng
Copy link
Contributor Author

/assign eahydra PTAL

@koordinator-bot
Copy link

@ZiMengSheng: GitHub didn't allow me to assign the following users: PTAL.

Note that only koordinator-sh members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign eahydra PTAL

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ZiMengSheng
Copy link
Contributor Author

/assign FillZpp eahydra hormes

@hormes
Copy link
Member

hormes commented Apr 24, 2024

/lgtm
/approve

@koordinator-bot koordinator-bot bot added the lgtm label Apr 24, 2024
@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit af172b1 into koordinator-sh:main Apr 24, 2024
20 checks passed
ZiMengSheng added a commit to ZiMengSheng/koordinator that referenced this pull request Apr 25, 2024
Signed-off-by: wangjianyu.wjy <wangjianyu.wjy@alibaba-inc.com>
Co-authored-by: wangjianyu.wjy <wangjianyu.wjy@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants