scheduler: optimize scheduleCycle logic when notEnoughChildren #2011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZiMengSheng
force-pushed
the
optimize_collect_enough
branch
3 times, most recently
from
77a2809
to
5749bd0
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2011 +/- ##
==========================================
- Coverage 68.81% 68.80% -0.02%
==========================================
Files 422 422
Lines 39022 39025 +3
==========================================
- Hits 26853 26851 -2
- Misses 9848 9856 +8
+ Partials 2321 2318 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ZiMengSheng
force-pushed
the
optimize_collect_enough
branch
3 times, most recently
from
19d2040
to
fceab82
Compare
ZiMengSheng
changed the title
ZiMengSheng
force-pushed
the
optimize_collect_enough
branch
from
fceab82
to
bff3d63
Compare
buptcozy
reviewed
Apr 18, 2024
Signed-off-by: wangjianyu.wjy <wangjianyu.wjy@alibaba-inc.com>
ZiMengSheng
force-pushed
the
optimize_collect_enough
branch
from
bff3d63
to
42d0009
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: buptcozy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
If the PreFilter of Coscheduling return UnschedulableAndUnresolvable since do not collect enough pods of a PodGroup, the PostFilter of Coscheduling will mark the schedule cycle invalid. But there is no need to do this, because once the Pods are collected enough, scheduling can be quickly performed instead of having to wait until the next cycle to actually start scheduling.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test