koordlet: revise node topology reporting for the kubelet cpu manager #2015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saintube
requested review from
shaloulcy,
ZiMengSheng,
jasonliu747 and
zwzhang0107
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2015 +/- ##
==========================================
+ Coverage 68.78% 68.80% +0.02%
==========================================
Files 422 422
Lines 39058 39061 +3
==========================================
+ Hits 26866 26877 +11
+ Misses 9865 9862 -3
+ Partials 2327 2322 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
zwzhang0107
reviewed
Apr 22, 2024
pkg/koordlet/statesinformer/impl/states_noderesourcetopology.go
Outdated
Show resolved
Hide resolved
saintube
force-pushed
the
koordlet-support-disable-kubelet-cpu-manager-reporting
branch
2 times, most recently
from
a5cc956
to
e58a3a7
Compare
Signed-off-by: saintube <saintube@foxmail.com>
saintube
force-pushed
the
koordlet-support-disable-kubelet-cpu-manager-reporting
branch
from
e58a3a7
to
80a327a
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zwzhang0107 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
node.koordinator.sh/node-cpu-allocseven if the Kubelet cpu manager policy is none or it failed to read the checkpoint file, instead of only updating when it succeeded in parsing the checkpoint file and at least one pod is managed by the static policy. It also helps when we want the koordlet to ignore the cpu manager cpuset in some special cases.cgroup-kube-dir. Add an argument to parameterize the host directory/var/lib/kubelet.Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test