scheduler: fix that cpu should be preferred if numa policy is restricted #2033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2033 +/- ##
==========================================
- Coverage 68.76% 68.74% -0.03%
==========================================
Files 423 423
Lines 39199 39199
==========================================
- Hits 26956 26946 -10
- Misses 9910 9918 +8
- Partials 2333 2335 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: KunWuLuan <kunwuluan@gmail.com>
KunWuLuan
changed the title
|
/lgtm |
saintube
changed the title
hormes
approved these changes
May 8, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
When pods request multi resources, and some of these resources need to be placed on 2 numa nodes and some other resources can be placed on 1 numa node, the pods can not be scheduled. This PR solve the problem by set preferred property to true for restricted policy and cpu resource to solve the problem.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Label a node that have 2 numa nodes with
node.koordinator.sh/numa-topology-policy=restrictedand create a pod that request 2 cpus and all gpu cards on node. The pod will be pending.Ⅳ. Special notes for reviews
V. Checklist
make test