-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scheduler: make device topology alignment switchable #2044
scheduler: make device topology alignment switchable #2044
Conversation
/hold this pr will be revised after 1.28.7 merged, because i want to move the switch to pluginArgs |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2044 +/- ##
==========================================
- Coverage 68.58% 68.58% -0.01%
==========================================
Files 430 430
Lines 39387 39400 +13
==========================================
+ Hits 27015 27021 +6
- Misses 10036 10038 +2
- Partials 2336 2341 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
57e8e6f
to
651845b
Compare
/hold cancel |
Signed-off-by: wangjianyu.wjy <wangjianyu.wjy@alibaba-inc.com>
651845b
to
35e70b2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FillZpp, hormes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test