Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler: make device topology alignment switchable #2044

Merged
merged 1 commit into from
May 25, 2024

Conversation

ZiMengSheng
Copy link
Contributor

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@koordinator-bot koordinator-bot bot requested review from eahydra and FillZpp May 13, 2024 02:10
@ZiMengSheng
Copy link
Contributor Author

/hold this pr will be revised after 1.28.7 merged, because i want to move the switch to pluginArgs

Copy link

codecov bot commented May 13, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 68.58%. Comparing base (f5b611f) to head (35e70b2).
Report is 6 commits behind head on main.

Files Patch % Lines
pkg/scheduler/plugins/deviceshare/topology_hint.go 0.00% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2044      +/-   ##
==========================================
- Coverage   68.58%   68.58%   -0.01%     
==========================================
  Files         430      430              
  Lines       39387    39400      +13     
==========================================
+ Hits        27015    27021       +6     
- Misses      10036    10038       +2     
- Partials     2336     2341       +5     
Flag Coverage Δ
unittests 68.58% <81.81%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ZiMengSheng
Copy link
Contributor Author

/hold cancel

Signed-off-by: wangjianyu.wjy <wangjianyu.wjy@alibaba-inc.com>
Copy link
Member

@FillZpp FillZpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@hormes
Copy link
Member

hormes commented May 25, 2024

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FillZpp, hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit f1afba1 into koordinator-sh:main May 25, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants