-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koordlet: add nri remove #2046
koordlet: add nri remove #2046
Conversation
/assign @saintube, PTAL. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2046 +/- ##
==========================================
- Coverage 68.75% 68.73% -0.02%
==========================================
Files 423 423
Lines 39246 39263 +17
==========================================
+ Hits 26985 26989 +4
- Misses 9928 9938 +10
- Partials 2333 2336 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
95fd0a7
to
1d5bd58
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Signed-off-by: Zhang Kang <kang.zhang@intel.com>
@jasonliu747 PTAL |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes, saintube The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ⅰ. Describe what this PR does
Add NRI RemovePodSandbox event handler into koordlet hook. It's part of the #1974. Resctrl runtime hook will leverage this to cleanup the resctrl group.
Ⅱ. Does this pull request fix one issue?
#1831
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test