Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koordlet: change CollectContainerThrottledMetric with duration=2*collectoInterval #2054

Merged

Conversation

zwzhang0107
Copy link
Contributor

…ectoInterval

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

…ectoInterval

Signed-off-by: 佑祎 <zzw261520@alibaba-inc.com>
@zwzhang0107 zwzhang0107 changed the title koordlet: change CollectContainerThrottledMetric with duration=2*coll… koordlet: change CollectContainerThrottledMetric with duration=2*collectoInterval May 21, 2024
Copy link
Member

@saintube saintube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saintube

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented May 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 68.58%. Comparing base (4bdcd66) to head (6ea7329).

Files Patch % Lines
pkg/koordlet/qosmanager/helpers/metrics_query.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2054   +/-   ##
=======================================
  Coverage   68.57%   68.58%           
=======================================
  Files         430      430           
  Lines       39383    39383           
=======================================
+ Hits        27006    27009    +3     
+ Misses      10039    10036    -3     
  Partials     2338     2338           
Flag Coverage Δ
unittests 68.58% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@koordinator-bot koordinator-bot bot merged commit eed98fa into koordinator-sh:main May 21, 2024
17 of 21 checks passed
@saintube saintube added this to the v1.5 milestone May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants