Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koordlet: fix BlkioReconcile file close #2056

Merged
merged 1 commit into from
May 23, 2024
Merged

koordlet: fix BlkioReconcile file close #2056

merged 1 commit into from
May 23, 2024

Conversation

testwill
Copy link
Contributor

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.59%. Comparing base (e6ae456) to head (a967ded).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2056      +/-   ##
==========================================
+ Coverage   68.57%   68.59%   +0.02%     
==========================================
  Files         430      430              
  Lines       39386    39387       +1     
==========================================
+ Hits        27007    27017      +10     
+ Misses      10041    10036       -5     
+ Partials     2338     2334       -4     
Flag Coverage Δ
unittests 68.59% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@saintube saintube changed the title fix: close file koordlet: fix BlkioReconcile file close May 22, 2024
@saintube
Copy link
Member

/lgtm

Signed-off-by: guangwu <guoguangwug@gmail.com>
@koordinator-bot koordinator-bot bot removed the lgtm label May 22, 2024
@saintube
Copy link
Member

/lgtm

@koordinator-bot koordinator-bot bot added the lgtm label May 22, 2024
@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saintube

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit f5b611f into koordinator-sh:main May 23, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants