Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler: enhance reservation error message #2058

Closed

Conversation

saintube
Copy link
Member

Ⅰ. Describe what this PR does

  • Enhance reservation error messages for printing unschedulable reasons by reservation-level.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign buptcozy after the PR has been reviewed.
You can assign the PR to them by writing /assign @buptcozy in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented May 23, 2024

Codecov Report

Attention: Patch coverage is 87.80488% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 68.60%. Comparing base (7e944d5) to head (8600a51).

Files Patch % Lines
pkg/scheduler/plugins/reservation/plugin.go 81.57% 7 Missing ⚠️
pkg/scheduler/plugins/reservation/transformer.go 91.17% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2058      +/-   ##
==========================================
+ Coverage   68.55%   68.60%   +0.05%     
==========================================
  Files         430      430              
  Lines       39387    39445      +58     
==========================================
+ Hits        27000    27061      +61     
+ Misses      10047    10045       -2     
+ Partials     2340     2339       -1     
Flag Coverage Δ
unittests 68.60% <87.80%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@saintube saintube force-pushed the scheduler-enhance-reservation-msg branch from 52dcaa4 to 7f259d5 Compare May 23, 2024 06:34
@saintube saintube force-pushed the scheduler-enhance-reservation-msg branch from 2ef40d5 to 4f4d8c4 Compare May 23, 2024 11:20
Signed-off-by: saintube <saintube@foxmail.com>
@saintube saintube force-pushed the scheduler-enhance-reservation-msg branch from 4f4d8c4 to 9276aa0 Compare May 24, 2024 08:41
Signed-off-by: saintube <saintube@foxmail.com>
@saintube saintube force-pushed the scheduler-enhance-reservation-msg branch from 9276aa0 to 8600a51 Compare May 24, 2024 08:51
@saintube
Copy link
Member Author

Merged by #2063.

@saintube saintube closed this May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants