Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler: make gang quickCheck earlier #2064

Merged
merged 1 commit into from
May 25, 2024

Conversation

ZiMengSheng
Copy link
Contributor

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Signed-off-by: wangjianyu.wjy <wangjianyu.wjy@alibaba-inc.com>
@ZiMengSheng ZiMengSheng changed the title scheduler: make gang PreCheck earlier scheduler: make gang quickCheck earlier May 24, 2024
@zwzhang0107
Copy link
Contributor

/lgtm

Copy link

codecov bot commented May 24, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 68.56%. Comparing base (7e944d5) to head (e2f5125).
Report is 3 commits behind head on main.

Files Patch % Lines
pkg/scheduler/plugins/coscheduling/coscheduling.go 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2064      +/-   ##
==========================================
+ Coverage   68.55%   68.56%   +0.01%     
==========================================
  Files         430      430              
  Lines       39387    39391       +4     
==========================================
+ Hits        27000    27007       +7     
+ Misses      10047    10043       -4     
- Partials     2340     2341       +1     
Flag Coverage Δ
unittests 68.56% <71.42%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hormes
Copy link
Member

hormes commented May 25, 2024

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit b8892e0 into koordinator-sh:main May 25, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants