-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koord-descheduler: balance prod pods between nodes in LowNodeLoad #2066
koord-descheduler: balance prod pods between nodes in LowNodeLoad #2066
Conversation
7768d8e
to
454d264
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2066 +/- ##
==========================================
- Coverage 68.75% 68.67% -0.09%
==========================================
Files 423 430 +7
Lines 39246 40065 +819
==========================================
+ Hits 26985 27516 +531
- Misses 9928 10182 +254
- Partials 2333 2367 +34
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
2905766
to
eafaba3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are several tiny coding style suggestions in your PR. However, we need to discuss about the available resources calculation logic again.
pkg/descheduler/framework/plugins/loadaware/utilization_util.go
Outdated
Show resolved
Hide resolved
pkg/descheduler/framework/plugins/loadaware/utilization_util.go
Outdated
Show resolved
Hide resolved
pkg/descheduler/framework/plugins/loadaware/utilization_util.go
Outdated
Show resolved
Hide resolved
pkg/descheduler/framework/plugins/loadaware/utilization_util.go
Outdated
Show resolved
Hide resolved
@zwForrest |
937d531
to
3a7588e
Compare
96bda67
to
9739766
Compare
pkg/descheduler/framework/plugins/loadaware/utilization_util.go
Outdated
Show resolved
Hide resolved
pkg/descheduler/framework/plugins/loadaware/utilization_util.go
Outdated
Show resolved
Hide resolved
pkg/descheduler/framework/plugins/loadaware/utilization_util.go
Outdated
Show resolved
Hide resolved
33dd07f
to
17cb270
Compare
/lgtm |
pkg/descheduler/framework/plugins/loadaware/utilization_util.go
Outdated
Show resolved
Hide resolved
d689d60
to
0a4c780
Compare
Signed-off-by: zwForrest <756495135@qq.com>
28f0d53
to
63f879b
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ⅰ. Describe what this PR does
Balance the usage of prod pods among nodes. Ensure that both the resource usage of prod pods on nodes and the overall node usage are balanced. This helps reduce the impact of node usage on prod applications.
Ⅱ. Does this pull request fix one issue?
fix #2043
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test