Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koord-descheduler: balance prod pods between nodes in LowNodeLoad #2066

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

zwForrest
Copy link
Contributor

Ⅰ. Describe what this PR does

Balance the usage of prod pods among nodes. Ensure that both the resource usage of prod pods on nodes and the overall node usage are balanced. This helps reduce the impact of node usage on prod applications.

Ⅱ. Does this pull request fix one issue?

fix #2043

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Copy link

codecov bot commented May 27, 2024

Codecov Report

Attention: Patch coverage is 88.85017% with 32 lines in your changes missing coverage. Please review.

Project coverage is 68.67%. Comparing base (afa430a) to head (63f879b).
Report is 34 commits behind head on main.

Files Patch % Lines
...er/framework/plugins/loadaware/utilization_util.go 93.08% 7 Missing and 6 partials ⚠️
...ler/apis/config/validation/validation_loadaware.go 0.00% 8 Missing and 2 partials ⚠️
...duler/framework/plugins/loadaware/low_node_load.go 91.95% 2 Missing and 5 partials ⚠️
...heduler/apis/config/v1alpha2/conversion_plugins.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2066      +/-   ##
==========================================
- Coverage   68.75%   68.67%   -0.09%     
==========================================
  Files         423      430       +7     
  Lines       39246    40065     +819     
==========================================
+ Hits        26985    27516     +531     
- Misses       9928    10182     +254     
- Partials     2333     2367      +34     
Flag Coverage Δ
unittests 68.67% <88.85%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zwForrest zwForrest force-pushed the feat/balanceProd branch 2 times, most recently from 2905766 to eafaba3 Compare May 30, 2024 08:59
Copy link
Contributor

@songtao98 songtao98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are several tiny coding style suggestions in your PR. However, we need to discuss about the available resources calculation logic again.

@songtao98
Copy link
Contributor

@zwForrest
The PR's title would be better using koord-descheduler: balance prod pods between nodes in LowNodeLoad.

@zwForrest zwForrest changed the title feat: balance prod pods between nodes koord-descheduler: balance prod pods between nodes in LowNodeLoad Jun 6, 2024
@songtao98
Copy link
Contributor

/lgtm

Signed-off-by: zwForrest <756495135@qq.com>
@songtao98
Copy link
Contributor

/lgtm

@koordinator-bot koordinator-bot bot added the lgtm label Jun 12, 2024
@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 4bd7021 into koordinator-sh:main Jun 13, 2024
22 checks passed
@zwForrest zwForrest deleted the feat/balanceProd branch July 10, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[proposal] deschedule production pods between nodes
3 participants