koordlet: fix nri reconnect params #2067
Conversation
Signed-off-by: saintube <saintube@foxmail.com>
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zwzhang0107 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2067 +/- ##
==========================================
- Coverage 68.63% 68.63% -0.01%
==========================================
Files 430 430
Lines 39518 39534 +16
==========================================
+ Hits 27125 27133 +8
- Misses 10049 10059 +10
+ Partials 2344 2342 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -248,13 +261,17 @@ func (p *NriServer) RemovePodSandbox(pod *api.PodSandbox) error { | |||
| func (p *NriServer) onClose() { | |||
| //TODO: consider the pod status during restart | |||
| retryFunc := func() (bool, error) { | |||
| stub, err := stub.New(p, append(opts, stub.WithOnClose(p.onClose))...) | |||
| if p.stopped.Load() { // if set to stopped, no longer reconnect | |||
There was a problem hiding this comment.
So, currently, nri server never stop, right ?
There was a problem hiding this comment.
Yes. Currently, this method is used by the testing.
Ⅰ. Describe what this PR does
TestNriServer_Startin the koordlet NRI module.Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test