Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some reservationAffinity related error #2072

Merged
merged 3 commits into from
May 29, 2024

Conversation

ZiMengSheng
Copy link
Contributor

@ZiMengSheng ZiMengSheng commented May 28, 2024

Ⅰ. Describe what this PR does

image

  1. deviceShare NUMA 感知调度未考虑 reseration Affinity
  2. reservation 插件未在 reserve 阶段和 prebind 阶段考虑 reservation 未找到但是又制定了 reservation affinity的情况
  3. DeviceShare restricted reservation 模式下插件返回的 status 未考虑外层分配不成功的情况

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Copy link

codecov bot commented May 28, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 68.62%. Comparing base (5de95c3) to head (c5507f2).

Files Patch % Lines
pkg/scheduler/plugins/reservation/plugin.go 20.00% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2072      +/-   ##
==========================================
- Coverage   68.62%   68.62%   -0.01%     
==========================================
  Files         430      430              
  Lines       39534    39538       +4     
==========================================
+ Hits        27130    27132       +2     
- Misses      10061    10062       +1     
- Partials     2343     2344       +1     
Flag Coverage Δ
unittests 68.62% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

wangjianyu.wjy added 3 commits May 29, 2024 10:31
Signed-off-by: wangjianyu.wjy <wangjianyu.wjy@alibaba-inc.com>
… affinity

Signed-off-by: wangjianyu.wjy <wangjianyu.wjy@alibaba-inc.com>
Signed-off-by: wangjianyu.wjy <wangjianyu.wjy@alibaba-inc.com>
@koordinator-bot koordinator-bot bot added size/S and removed size/XS labels May 29, 2024
@ZiMengSheng ZiMengSheng changed the title scheduler: fix deviceShare numa not consider reservationAffinity fix some reservationAffinity related error May 29, 2024
@zwzhang0107
Copy link
Contributor

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: zwzhang0107

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit a685498 into koordinator-sh:main May 29, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants