-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koord-descheduler: fix object limiter by move it to reconciler #2088
koord-descheduler: fix object limiter by move it to reconciler #2088
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2088 +/- ##
==========================================
+ Coverage 68.65% 68.66% +0.01%
==========================================
Files 430 430
Lines 40056 40078 +22
==========================================
+ Hits 27499 27520 +21
+ Misses 10192 10188 -4
- Partials 2365 2370 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
42c21e9
to
513a270
Compare
513a270
to
96f7d53
Compare
2f80906
to
b7414ba
Compare
9e98f5c
to
bc45a0b
Compare
Signed-off-by: songtao98 <songtao2603060@gmail.com>
bc45a0b
to
7fa537d
Compare
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ⅰ. Describe what this PR does
The arbitrator relies on golang's
rate.Limiter
package to implement workload-level eviction limter. However, only when theMigrationController
evicts a pod successfully, the limiter's tokens will be consumed. That leads to a high possibility that the number ofPodMigrationJob
passes the arbitration is more than objectLimiter's upper bound, so that we cannot really limit the number of pods being evicted inside a timewindow.This PR moves the objectlimiter from arbitrator to reconciler. Thus it can be checked based on the real number.
Ⅱ. Does this pull request fix one issue?
fixes #2074
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test