Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler: reduce cycleState overhead for reservation #2120

Conversation

saintube
Copy link
Member

Ⅰ. Describe what this PR does

scheduler: fix the memory overhead issue for the reservation cycleState.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Signed-off-by: saintube <saintube@foxmail.com>
Copy link

codecov bot commented Jun 28, 2024

Codecov Report

Attention: Patch coverage is 59.09091% with 9 lines in your changes missing coverage. Please review.

Project coverage is 68.71%. Comparing base (61e47f0) to head (e9a15d1).
Report is 1 commits behind head on main.

Files Patch % Lines
pkg/scheduler/plugins/reservation/plugin.go 30.76% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2120      +/-   ##
==========================================
+ Coverage   68.69%   68.71%   +0.02%     
==========================================
  Files         430      430              
  Lines       40180    40188       +8     
==========================================
+ Hits        27603    27617      +14     
+ Misses      10207    10205       -2     
+ Partials     2370     2366       -4     
Flag Coverage Δ
unittests 68.71% <59.09%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ZiMengSheng
Copy link
Contributor

/lgtm

@ZiMengSheng
Copy link
Contributor

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ZiMengSheng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 4a61e34 into koordinator-sh:main Jul 2, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants