Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koordlet: Add resctrl runtime hook for pod level #2123

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kangclzjc
Copy link
Member

Ⅰ. Describe what this PR does

Add resctrl runtime hook for pod level. It's part of the #1974.

Ⅱ. Does this pull request fix one issue?

#1831

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign jasonliu747 after the PR has been reviewed.
You can assign the PR to them by writing /assign @jasonliu747 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Jul 3, 2024

Codecov Report

Attention: Patch coverage is 23.52941% with 221 lines in your changes missing coverage. Please review.

Project coverage is 68.39%. Comparing base (0db9ea2) to head (2cf58c1).
Report is 1 commits behind head on main.

Files Patch % Lines
pkg/koordlet/util/resctrl/resctrl.go 0.00% 161 Missing ⚠️
pkg/koordlet/util/resctrl/ctrl_mgr.go 62.63% 26 Missing and 8 partials ⚠️
pkg/koordlet/runtimehooks/reconciler/reconciler.go 45.83% 13 Missing ⚠️
pkg/koordlet/runtimehooks/protocol/protocol.go 0.00% 10 Missing ⚠️
...et/qosmanager/plugins/resctrl/resctrl_reconcile.go 0.00% 1 Missing and 1 partial ⚠️
pkg/koordlet/runtimehooks/protocol/pod_context.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2123      +/-   ##
==========================================
- Coverage   68.71%   68.39%   -0.32%     
==========================================
  Files         430      432       +2     
  Lines       40298    40587     +289     
==========================================
+ Hits        27689    27760      +71     
- Misses      10232    10443     +211     
- Partials     2377     2384       +7     
Flag Coverage Δ
unittests 68.39% <23.52%> (-0.32%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Zhang Kang <kang.zhang@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant