Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler: fix reserveNUMAResource bug #2124

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

ZiMengSheng
Copy link
Contributor

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Copy link

codecov bot commented Jul 3, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 5 lines in your changes missing coverage. Please review.

Project coverage is 68.71%. Comparing base (4a61e34) to head (bac91b3).

Files Patch % Lines
.../scheduler/plugins/nodenumaresource/reservation.go 71.42% 4 Missing ⚠️
...cheduler/plugins/nodenumaresource/topology_hint.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2124      +/-   ##
==========================================
+ Coverage   68.69%   68.71%   +0.02%     
==========================================
  Files         430      430              
  Lines       40202    40245      +43     
==========================================
+ Hits        27615    27654      +39     
- Misses      10215    10221       +6     
+ Partials     2372     2370       -2     
Flag Coverage Δ
unittests 68.71% <88.88%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: wangjianyu.wjy <wangjianyu.wjy@alibaba-inc.com>
@hormes
Copy link
Member

hormes commented Jul 3, 2024

/lgtm

@ZiMengSheng
Copy link
Contributor Author

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ZiMengSheng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 091f73e into koordinator-sh:main Jul 3, 2024
18 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants