Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler:support multi gpu share #2127

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AdrianMachao
Copy link

@AdrianMachao AdrianMachao commented Jul 5, 2024

Ⅰ. Describe what this PR does

support multi gpu share

Ⅱ. Does this pull request fix one issue?

#2097

Ⅲ. Describe how to verify it

use gpushare resource follow proposal

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Copy link

codecov bot commented Jul 5, 2024

Codecov Report

Attention: Patch coverage is 67.18750% with 63 lines in your changes missing coverage. Please review.

Project coverage is 68.64%. Comparing base (6861c87) to head (81f2016).

Files Patch % Lines
...g/webhook/pod/validating/verify_device_resource.go 65.06% 22 Missing and 7 partials ⚠️
pkg/scheduler/plugins/deviceshare/utils.go 22.72% 17 Missing ⚠️
...r/noderesource/plugins/gpudeviceresource/plugin.go 62.50% 4 Missing and 2 partials ⚠️
pkg/webhook/pod/mutating/device_resource_spec.go 92.59% 2 Missing and 2 partials ⚠️
pkg/webhook/pod/validating/validating_handler.go 33.33% 2 Missing and 2 partials ⚠️
pkg/webhook/pod/mutating/mutating_handler.go 0.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2127      +/-   ##
==========================================
- Coverage   68.68%   68.64%   -0.04%     
==========================================
  Files         435      437       +2     
  Lines       40703    40886     +183     
==========================================
+ Hits        27955    28065     +110     
- Misses      10337    10392      +55     
- Partials     2411     2429      +18     
Flag Coverage Δ
unittests 68.64% <67.18%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign fillzpp, jasonliu747, zimengsheng after the PR has been reviewed.
You can assign the PR to them by writing /assign @fillzpp @jasonliu747 @zimengsheng in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: machao <986292120@qq.com>
@AdrianMachao
Copy link
Author

AdrianMachao commented Jul 13, 2024

@FillZpp @jasonliu747 @ZiMengSheng PTAL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants