koord-manager: support manually configured default cpu normalization settings #2128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2128 +/- ##
=======================================
Coverage 68.68% 68.68%
=======================================
Files 435 435
Lines 40703 40712 +9
=======================================
+ Hits 27955 27965 +10
Misses 10337 10337
+ Partials 2411 2410 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
saintube
reviewed
Jul 9, 2024
yangfeiyu20102011
changed the title
saintube
reviewed
Jul 9, 2024
pkg/slo-controller/noderesource/plugins/cpunormalization/plugin.go
Outdated
Show resolved
Hide resolved
yangfeiyu20102011
force-pushed
the
main
branch
2 times, most recently
from
d933be0
to
87a511f
Compare
saintube
reviewed
Jul 9, 2024
pkg/slo-controller/noderesource/plugins/cpunormalization/plugin.go
Outdated
Show resolved
Hide resolved
|
/lgtm |
|
PTAL /cc @hormes |
…settings In some dedicated clusters, we don't need complex CPU models; instead, we prefer manually configured default CPU normalization settings for greater flexibility. Signed-off-by: yangfeiyu20102011 <yangfeiyu20102011@163.com>
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes, saintube, zwzhang0107 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
zwForrest
pushed a commit
to zwForrest/koordinator
that referenced
this pull request
Jul 16, 2024
…settings (koordinator-sh#2128) Signed-off-by: yangfeiyu20102011 <yangfeiyu20102011@163.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some dedicated clusters, we don't need complex CPU models; instead, we prefer manually configured default CPU normalization settings for greater flexibility.
Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test