-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koord-manager: support manually configured default cpu normalization settings #2128
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2128 +/- ##
=======================================
Coverage 68.68% 68.68%
=======================================
Files 435 435
Lines 40703 40712 +9
=======================================
+ Hits 27955 27965 +10
Misses 10337 10337
+ Partials 2411 2410 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pkg/slo-controller/noderesource/plugins/cpunormalization/plugin.go
Outdated
Show resolved
Hide resolved
d933be0
to
87a511f
Compare
pkg/slo-controller/noderesource/plugins/cpunormalization/plugin.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/lgtm |
PTAL /cc @hormes |
…settings In some dedicated clusters, we don't need complex CPU models; instead, we prefer manually configured default CPU normalization settings for greater flexibility. Signed-off-by: yangfeiyu20102011 <yangfeiyu20102011@163.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes, saintube, zwzhang0107 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…settings (koordinator-sh#2128) Signed-off-by: yangfeiyu20102011 <yangfeiyu20102011@163.com>
In some dedicated clusters, we don't need complex CPU models; instead, we prefer manually configured default CPU normalization settings for greater flexibility.
Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test