-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
webhook: add quota evaluate webhook #2129
webhook: add quota evaluate webhook #2129
Conversation
Signed-off-by: chuanyun.lcy <chuanyun.lcy@alibaba-inc.com>
Signed-off-by: chuanyun.lcy <chuanyun.lcy@alibaba-inc.com>
d2db7a9
to
d517e7d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2129 +/- ##
==========================================
- Coverage 68.69% 68.66% -0.03%
==========================================
Files 430 435 +5
Lines 40202 40703 +501
==========================================
+ Hits 27615 27949 +334
- Misses 10215 10344 +129
- Partials 2372 2410 +38
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ⅰ. Describe what this PR does
add quota evaluate webhook. if the pod requests exceed max or admission, the webhook will reject the create
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test