koord-descheduler: Fix threshold initialization for prod. #2130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zwForrest
force-pushed
the
fix-descheduler
branch
from
7b84259
to
9f142ac
Compare
|
@songtao98 PTAL |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2130 +/- ##
==========================================
+ Coverage 67.91% 67.93% +0.02%
==========================================
Files 441 441
Lines 41521 41527 +6
==========================================
+ Hits 28197 28213 +16
+ Misses 10899 10892 -7
+ Partials 2425 2422 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
zwForrest
changed the title
zwForrest
force-pushed
the
fix-descheduler
branch
from
77db677
to
77062cf
Compare
|
/lgtm |
zwForrest
force-pushed
the
fix-descheduler
branch
from
8715046
to
1a7f507
Compare
Signed-off-by: zwForrest <756495135@qq.com>
zwForrest
force-pushed
the
fix-descheduler
branch
from
1a7f507
to
777679d
Compare
|
/lgtm |
|
/approved |
hormes
approved these changes
Jul 16, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
Fix threshold initialization for prod when useDeviationThresholds mode is true. Add more debug log.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test