-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koord-descheduler: Fix threshold initialization for prod. #2130
koord-descheduler: Fix threshold initialization for prod. #2130
Conversation
7b84259
to
9f142ac
Compare
@songtao98 PTAL |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2130 +/- ##
==========================================
+ Coverage 67.91% 67.93% +0.02%
==========================================
Files 441 441
Lines 41521 41527 +6
==========================================
+ Hits 28197 28213 +16
+ Misses 10899 10892 -7
+ Partials 2425 2422 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
77db677
to
77062cf
Compare
/lgtm |
8715046
to
1a7f507
Compare
Signed-off-by: zwForrest <756495135@qq.com>
1a7f507
to
777679d
Compare
/lgtm |
/approved |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ⅰ. Describe what this PR does
Fix threshold initialization for prod when useDeviationThresholds mode is true. Add more debug log.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test