Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koordlet: upgrade nri to 0.6.1 #2132

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

kangclzjc
Copy link
Member

@kangclzjc kangclzjc commented Jul 11, 2024

Ⅰ. Describe what this PR does

Upgrade NRI to 0.6.1

Ⅱ. Does this pull request fix one issue?

fixes #2131

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Copy link

codecov bot commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.68%. Comparing base (6861c87) to head (710077a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2132   +/-   ##
=======================================
  Coverage   68.68%   68.68%           
=======================================
  Files         435      435           
  Lines       40703    40703           
=======================================
+ Hits        27955    27958    +3     
+ Misses      10337    10336    -1     
+ Partials     2411     2409    -2     
Flag Coverage Δ
unittests 68.68% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kangclzjc
Copy link
Member Author

@saintube PTAL.

Signed-off-by: Zhang Kang <kang.zhang@intel.com>
Copy link
Member

@saintube saintube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@hormes
Copy link
Member

hormes commented Jul 15, 2024

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes, saintube

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit e003d3e into koordinator-sh:main Jul 15, 2024
22 checks passed
zwForrest pushed a commit to zwForrest/koordinator that referenced this pull request Jul 16, 2024
Signed-off-by: Zhang Kang <kang.zhang@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[dependency] Upgrade github.com/containerd/nri to v0.6.1
3 participants