-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
webhook: revise elasticquota mutating when validating disabled #2135
webhook: revise elasticquota mutating when validating disabled #2135
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2135 +/- ##
==========================================
- Coverage 67.91% 67.86% -0.05%
==========================================
Files 441 441
Lines 41547 41569 +22
==========================================
- Hits 28215 28212 -3
- Misses 10902 10927 +25
Partials 2430 2430
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: saintube <saintube@foxmail.com>
3b8e691
to
81c38fb
Compare
/lgtm |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…inator-sh#2135) Signed-off-by: saintube <saintube@foxmail.com>
Ⅰ. Describe what this PR does
In the current version of the koord-manager, the event handler of the elastic quota reconciling the quota topology cache is only instantiated by the elastic quota validating handler. It means the handler cannot work well when we enable the quota mutating but disable quota validating since the topology cache is invalid.
To fix this issue, we also try instantiating the event handler of the elastic quota in the quota mutating handler when it has not been instantiated.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test