Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add read only port support for koordlet #320

Merged
merged 1 commit into from
Jun 29, 2022

Conversation

LambdaHJ
Copy link
Contributor

Signed-off-by: 黄金 heikkihuang@kugou.net

Ⅰ. Describe what this PR does

add read only port support for koordlet.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented Jun 29, 2022

Codecov Report

Merging #320 (d2aa7dd) into main (5da05b3) will increase coverage by 1.21%.
The diff coverage is 70.27%.

@@            Coverage Diff             @@
##             main     #320      +/-   ##
==========================================
+ Coverage   63.30%   64.51%   +1.21%     
==========================================
  Files         106      113       +7     
  Lines        9725    11164    +1439     
==========================================
+ Hits         6156     7203    +1047     
- Misses       3073     3386     +313     
- Partials      496      575      +79     
Flag Coverage Δ
unittests 64.51% <70.27%> (+1.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/koordlet/statesinformer/states_informer.go 42.10% <65.00%> (+2.84%) ⬆️
pkg/koordlet/statesinformer/kubelet_stub.go 62.50% <76.47%> (-4.17%) ⬇️
.../koordlet/runtimehooks/hooks/groupidentity/rule.go 86.59% <0.00%> (-3.73%) ⬇️
pkg/koordlet/statesinformer/states_node.go 25.80% <0.00%> (-1.78%) ⬇️
pkg/koordlet/statesinformer/config.go 100.00% <0.00%> (ø)
pkg/koordlet/statesinformer/register.go 70.17% <0.00%> (ø)
...cheduler/plugins/nodenumaresource/plugin_helper.go 78.26% <0.00%> (ø)
...cheduler/plugins/nodenumaresource/cpu_allocator.go 82.94% <0.00%> (ø)
...scheduler/plugins/nodenumaresource/cpu_topology.go 30.35% <0.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5da05b3...d2aa7dd. Read the comment docs.

Signed-off-by: 黄金 <heikkihuang@kugou.net>
Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@saintube
Copy link
Member

/lgtm

@hormes
Copy link
Member

hormes commented Jun 29, 2022

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit b21ea49 into koordinator-sh:main Jun 29, 2022
@jasonliu747 jasonliu747 added this to the v0.5 milestone Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants