-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup: Use the structure as the key of the map instead of string #349
Conversation
Codecov Report
@@ Coverage Diff @@
## main #349 +/- ##
=======================================
Coverage 64.85% 64.85%
=======================================
Files 116 116
Lines 11451 11451
=======================================
Hits 7426 7426
Misses 3440 3440
Partials 585 585
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
thanks for your pr |
Signed-off-by: h30003300 <heqian28@huawei.com>
hi @ZYecho squashed it. PTAL~ |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
…or-sh#349) Signed-off-by: h30003300 <heqian28@huawei.com>
Ⅰ. Describe what this PR does
Use the structure as the key of the map instead of string
refer:
https://github.com/golang/groupcache/blob/41bb18bfe9da5321badc438f91158cd790a33aa3/lru/lru.go#L36-L37
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test