Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: Use the structure as the key of the map instead of string #349

Merged
merged 1 commit into from
Jul 7, 2022

Conversation

novahe
Copy link
Contributor

@novahe novahe commented Jul 7, 2022

Ⅰ. Describe what this PR does

Use the structure as the key of the map instead of string

refer:
https://github.com/golang/groupcache/blob/41bb18bfe9da5321badc438f91158cd790a33aa3/lru/lru.go#L36-L37

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@koordinator-bot koordinator-bot bot requested review from honpey and ZYecho July 7, 2022 06:51
@novahe novahe changed the title Use the structure as the key of the map instead of string cleanup: Use the structure as the key of the map instead of string Jul 7, 2022
@codecov
Copy link

codecov bot commented Jul 7, 2022

Codecov Report

Merging #349 (1f269d7) into main (54ed9a5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #349   +/-   ##
=======================================
  Coverage   64.85%   64.85%           
=======================================
  Files         116      116           
  Lines       11451    11451           
=======================================
  Hits         7426     7426           
  Misses       3440     3440           
  Partials      585      585           
Flag Coverage Δ
unittests 64.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54ed9a5...1f269d7. Read the comment docs.

@ZYecho
Copy link
Contributor

ZYecho commented Jul 7, 2022

thanks for your pr
please squash your commits

Signed-off-by: h30003300 <heqian28@huawei.com>
@novahe
Copy link
Contributor Author

novahe commented Jul 7, 2022

hi @ZYecho squashed it. PTAL~

@ZYecho
Copy link
Contributor

ZYecho commented Jul 7, 2022

/lgtm

@hormes
Copy link
Member

hormes commented Jul 7, 2022

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@koordinator-bot koordinator-bot bot merged commit 1328009 into koordinator-sh:main Jul 7, 2022
@jasonliu747 jasonliu747 added this to the v0.6 milestone Jul 19, 2022
jasonliu747 pushed a commit to jasonliu747/koordinator that referenced this pull request Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants