Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: add device CRD in scheduling group #376

Merged
merged 1 commit into from
Jul 18, 2022

Conversation

jasonliu747
Copy link
Member

Signed-off-by: Jason Liu jasonliu747@gmail.com

Ⅰ. Describe what this PR does

Define Device CRD according to this proposal: https://github.com/koordinator-sh/koordinator/blob/main/docs/proposals/scheduling/20220629-fine-grained-device-scheduling.md

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented Jul 18, 2022

Codecov Report

Merging #376 (37844d9) into main (c9cf1a4) will decrease coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #376      +/-   ##
==========================================
- Coverage   66.55%   66.49%   -0.07%     
==========================================
  Files         116      116              
  Lines       11580    11580              
==========================================
- Hits         7707     7700       -7     
- Misses       3283     3290       +7     
  Partials      590      590              
Flag Coverage Δ
unittests 66.49% <ø> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/koordlet/runtimehooks/reconciler/reconciler.go 71.57% <0.00%> (-7.37%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9cf1a4...37844d9. Read the comment docs.

Signed-off-by: Jason Liu <jasonliu747@gmail.com>
@jasonliu747
Copy link
Member Author

/hold for #377
/cc @eahydra @buptcozy @hormes

@koordinator-bot
Copy link

@jasonliu747: GitHub didn't allow me to request PR reviews from the following users: buptcozy.

Note that only koordinator-sh members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/hold for #377
/cc @eahydra @buptcozy @hormes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jasonliu747
Copy link
Member Author

/hold cancel

Copy link
Member

@eahydra eahydra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@hormes
Copy link
Member

hormes commented Jul 18, 2022

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eahydra, hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 91cacc4 into koordinator-sh:main Jul 18, 2022
@jasonliu747 jasonliu747 added this to the v0.6 milestone Jul 18, 2022
@jasonliu747 jasonliu747 deleted the device-crd branch July 19, 2022 14:28
@jasonliu747 jasonliu747 modified the milestones: v0.6, v0.7 Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants