Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: update reservation api #384

Merged

Conversation

saintube
Copy link
Member

Signed-off-by: saintube saintube@foxmail.com

Ⅰ. Describe what this PR does

update reservation API

Ⅱ. Does this pull request fix one issue?

related to #188

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@saintube
Copy link
Member Author

/assign @eahydra @hormes @jasonliu747 @allwmh

@codecov
Copy link

codecov bot commented Jul 20, 2022

Codecov Report

Merging #384 (10e2a93) into main (dab5a92) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #384   +/-   ##
=======================================
  Coverage   66.50%   66.50%           
=======================================
  Files         116      116           
  Lines       11669    11669           
=======================================
  Hits         7760     7760           
  Misses       3308     3308           
  Partials      601      601           
Flag Coverage Δ
unittests 66.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dab5a92...10e2a93. Read the comment docs.

@eahydra eahydra self-requested a review July 20, 2022 06:42
Copy link
Member

@eahydra eahydra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@koordinator-bot koordinator-bot bot added the lgtm label Jul 20, 2022
Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Signed-off-by: saintube <saintube@foxmail.com>
Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@koordinator-bot koordinator-bot bot added the lgtm label Jul 20, 2022
@hormes
Copy link
Member

hormes commented Jul 20, 2022

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes, jasonliu747

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 74de8bd into koordinator-sh:main Jul 20, 2022
jasonliu747 pushed a commit to jasonliu747/koordinator that referenced this pull request Jul 26, 2022
Signed-off-by: saintube <saintube@foxmail.com>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants