-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add groupQuotaManager #541
add groupQuotaManager #541
Conversation
462b360
to
836fd6d
Compare
836fd6d
to
128b895
Compare
128b895
to
e002c39
Compare
e002c39
to
7c195e5
Compare
Codecov Report
@@ Coverage Diff @@
## main #541 +/- ##
==========================================
+ Coverage 68.33% 68.92% +0.59%
==========================================
Files 159 161 +2
Lines 17891 18382 +491
==========================================
+ Hits 12225 12669 +444
- Misses 4762 4807 +45
- Partials 904 906 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
7c195e5
to
ef5ca54
Compare
ef5ca54
to
44dc17c
Compare
44dc17c
to
a98b6ed
Compare
pkg/scheduler/plugins/elasticquota/core/scale_minquota_when_over_root_res.go
Outdated
Show resolved
Hide resolved
pkg/scheduler/plugins/elasticquota/core/scale_minquota_when_over_root_res.go
Show resolved
Hide resolved
pkg/scheduler/plugins/elasticquota/core/scale_minquota_when_over_root_res.go
Outdated
Show resolved
Hide resolved
pkg/scheduler/plugins/elasticquota/core/scale_minquota_when_over_root_res.go
Outdated
Show resolved
Hide resolved
pkg/scheduler/plugins/elasticquota/core/scale_minquota_when_over_root_res.go
Outdated
Show resolved
Hide resolved
pkg/scheduler/plugins/elasticquota/core/scale_minquota_when_over_root_res.go
Outdated
Show resolved
Hide resolved
Signed-off-by: xulinfei.xlf <xulinfei.xlf@alibaba-inc.com>
ddfe23f
to
50bfaf4
Compare
50bfaf4
to
bad91a8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/LGTM
1b22a4b
to
2b66878
Compare
2b66878
to
ce4610f
Compare
goos: darwin goarch: amd64 cpu: Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz BenchmarkGroupQuotaManager_RefreshRuntime-12 6393 211792 ns/op Signed-off-by: xulinfei.xlf <xulinfei.xlf@alibaba-inc.com>
ce4610f
to
836bff2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: buptcozy, eahydra, hormes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: xulinfei.xlf xulinfei.xlf@alibaba-inc.com
Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test